andrewgaul requested changes on this pull request.
> @@ -51,6 +51,11 @@
<artifactId>google-compute-engine</artifactId>
<version>${jclouds.version}</version>
</dependency>
+ <dependency>
+ <groupId>io.cloudsoft.jclouds.api</groupId>
+ <artifactId>openstack-mitaka-nova</artifactId>
+ <version>1.9.3-cloudsoft.20160831</version>
+ </dependency>
What is this for?
> // Create Container
- BlobStore blobStore = context.getBlobStore();
Location location = null;
These changes disappeared in the latest PR, but you could allow
`jclouds.region` property to set a non-default `location`.
> // note that you can check if a provider is present ahead of time
checkArgument(contains(allKeys, provider), "provider %s not in supported
list: %s", provider, allKeys);
-
- String identity = args[1];
- String credential = args[2];
- String containerName = args[3];
+ identity = args[1];
+ credential = args[2];
+ containerName = args[3];
+ if (args.length > 4) endpoint = args[4];
Could use `jclouds.endpoint` property.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/90#pullrequestreview-10093871