nacx commented on this pull request. Thanks for the fix @felfert!
Since we don't support yet tags (we should implement the [tag api](https://developers.digitalocean.com/documentation/v2/#tags) and open a JIRA to track this), I think there is no need to keep using the `metadataAndTagsAsCommaDelimitedValue` helper method, as it could lead to confusion. The problem is that the jclouds `TemplateOptions#userMetadata` is a `Map<String, String>`, and does not properly match DigitalOcean `user_data`. I think the proposed approach is OK, and that we could assume users willing to set this, will provide a map with a "user_data" key. Mind changing the PR to just read the `TempalteOptions.getUserMetadata()` and filing a JIRA issue for the Tag support? We'd also better change [this comment](https://github.com/jclouds/jclouds/blob/master/providers/digitalocean2/src/test/java/org/jclouds/digitalocean2/compute/DigitalOcean2ComputeServiceLiveTest.java#L58) to properly indicate we don't support tags yet. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1042#pullrequestreview-10216138
