demobox commented on this pull request.
> @@ -20,7 +20,7 @@
<configuration>
<appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
<encoder>
- <pattern>- %msg%n</pattern>
+ <pattern>%msg%n</pattern>
How does this compare with the logging for other examples?
> <artifactId>docker</artifactId>
- <!-- TODO: Update version to variable jclouds.version on next release
-->
- <version>2.0.0-SNAPSHOT</version>
+ <version>${jclouds.version}</version>
Have we been able to verify that this change works as expected?
> @@ -87,10 +87,7 @@ private Instance getInstance() {
private void createDatabase() throws TimeoutException {
System.out.format("Create Database%n");
-
- boolean result = databaseApi.create(NAME);
-
- System.out.format(" %s%n", result);
+ databaseApi.create(NAME);
Any reason for dropping the logging here?
> @@ -85,10 +85,7 @@ private Instance getInstance() {
private void createUser() throws TimeoutException {
System.out.format("Create User%n");
-
- boolean result = userApi.create(NAME, PASSWORD, NAME);
-
- System.out.format(" %s%n", result);
+ userApi.create(NAME, PASSWORD, NAME);
Same comment as above
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/91#pullrequestreview-10221508
