@andreaturli I've just added all the mentioned code cleanup and introduced the resource group cache. Please have a look.
All extension live tests are green. I'll run the compute service adapter ones in a while. ```bash Starting test testCreateSecurityGroup(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest) [pool-1-thread-1] Test testCreateSecurityGroup(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest) succeeded: 1215ms Test suite progress: tests succeeded: 1, failed: 0, skipped: 0. Starting test testCreateNodeWithInboundPorts(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest) [pool-1-thread-2] Test testCreateNodeWithInboundPorts(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest) succeeded: 325603ms Test suite progress: tests succeeded: 2, failed: 0, skipped: 0. Starting test testCreateNodeWithSecurityGroup(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest) [pool-1-thread-2] Test testCreateNodeWithSecurityGroup(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest) succeeded: 475649ms Test suite progress: tests succeeded: 3, failed: 0, skipped: 0. Starting test testGetSecurityGroupById(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest) [pool-1-thread-2] Test testGetSecurityGroupById(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest) succeeded: 27745ms Test suite progress: tests succeeded: 4, failed: 0, skipped: 0. Starting test testAddIpPermission(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest) [pool-1-thread-3] Test testAddIpPermission(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest) succeeded: 3496ms Test suite progress: tests succeeded: 5, failed: 0, skipped: 0. Starting test testRemoveIpPermission(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest) [pool-1-thread-4] Test testRemoveIpPermission(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest) succeeded: 3441ms Test suite progress: tests succeeded: 6, failed: 0, skipped: 0. Starting test testAddIpPermissionsFromSpec(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest) [pool-1-thread-5] Test testAddIpPermissionsFromSpec(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest) succeeded: 1750ms Test suite progress: tests succeeded: 7, failed: 0, skipped: 0. Starting test testAddIpPermissionWithCidrExclusionGroup(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest) [pool-1-thread-5] Test testAddIpPermissionWithCidrExclusionGroup(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest) skipped. Test suite progress: tests succeeded: 7, failed: 0, skipped: 1. [pool-1-thread-5] Test testRemoveIpPermissionWithCidrExclusionGroup(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest) skipped. Test suite progress: tests succeeded: 7, failed: 0, skipped: 2. Starting test testDeleteSecurityGroup(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest) [pool-1-thread-5] Test testDeleteSecurityGroup(org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest) succeeded: 705ms Test suite progress: tests succeeded: 8, failed: 0, skipped: 2. Tests run: 10, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 970.066 sec - in org.jclouds.azurecompute.arm.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest Results : Tests run: 10, Failures: 0, Errors: 0, Skipped: 2 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/347#issuecomment-275371290
