nacx requested changes on this pull request.
> @@ -200,8 +200,8 @@
for (Version version : versionList) {
Version versionDetails = osImageApi.getVersion(publisherName,
offer.name(), sku.name(), version.name());
VMImage vmImage =
VMImage.azureImage().publisher(publisherName).offer(offer.name()).sku(sku.name())
-
.version(versionDetails.name()).location(location).versionProperties(versionDetails.properties())
- .build();
+
.version(versionDetails.name()).location(location).versionProperties(versionDetails.properties())
+ .build();
osImagesRef.add(vmImage);
}
}
Discard the changes in this class.
> - family =
> OsFamily.fromValue(image.versionProperties().osDiskImage().operatingSystem().toUpperCase());
+ if (OsFamily.UNRECOGNIZED == family) {
+// &&
+// } image.versionProperties() != null
+// && image.versionProperties().osDiskImage() != null
+// &&
image.versionProperties().osDiskImage().operatingSystem() != null) {
+
+
+
+
+// Version versionDetails = osImageApi.getVersion(publisherName,
offer.name(), sku.name(), version.name());
+// VMImage vmImage =
VMImage.azureImage().publisher(publisherName).offer(offer.name()).sku(sku.name())
+//
.version(versionDetails.name()).location(location).versionProperties(versionDetails.properties())
+// .build();
+
+// family =
OsFamily.fromValue(image.versionProperties().osDiskImage().operatingSystem().toUpperCase());
}
// only 64bit OS images are supported by Azure ARM
Discard the changes in this class.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/351#pullrequestreview-18855599
