neykov approved this pull request.
All good - some minor cleanups noted.
> - <feature name='jclouds-api-openstack-swift' description='jclouds - API -
> OpenStack Swift' version='${project.version}' resolver='(obr)'>
+ <feature name="jclouds-api-cloudwatch" description="jclouds - API -
Cloudwatch" version="${project.version}" resolver="(obr)">
+ <feature version='${project.version}'>jclouds-compute</feature>
+ <feature version='${project.version}'>jclouds-api-sts</feature>
+
<bundle>mvn:org.apache.jclouds.api/cloudwatch/${jclouds.version}</bundle>
+ </feature>
+
+ <feature name='jclouds-api-docker' description='jclouds - API - Docker'
version='${project.version}'>
+ <feature version='${project.version}'>jclouds-compute</feature>
+ <feature
version='${project.version}'>jclouds-driver-bouncycastle</feature>
+ <feature version='${project.version}'>jclouds-driver-okhttp</feature>
+ <feature version='${project.version}'>jclouds-api-oauth</feature>
+ <bundle>mvn:org.apache.jclouds.api/docker/${jclouds.version}</bundle>
+ </feature>
+
+ <feature name="jclouds-api-ec2" description="jclouds - API - EC2"
version="${project.version}" resolver="(obr)">
Leftover `resolver` attribute here and elsewhere in the file.
> + <feature>jclouds-cloudsigma2-hnl</feature>
+ <feature>jclouds-cloudsigma2-lvs</feature>
+ <feature>jclouds-cloudsigma2-sjc</feature>
+ <feature>jclouds-cloudsigma2-wdc</feature>
+ <feature>jclouds-cloudsigma2-zrh</feature>
+ <feature>jclouds-google-cloud-storage</feature>
+ <feature>jclouds-packet</feature>
+ <feature>jclouds-vagrant</feature>
+ </features>
+ <repository>target/features-repo</repository>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
That's probably a historic baggage. All that's needed in a feature pom is:
```
<artifactId>...</artifactId>
<name>.....</name>
<packaging>feature</packaging>
<build>
<plugins>
<plugin>
<groupId>org.apache.karaf.tooling</groupId>
<artifactId>karaf-maven-plugin</artifactId>
<version>${karaf.plugin.version}</version>
<extensions>true</extensions>
</plugin>
</plugins>
</build>
```
To verify it's still working after the change make sure you still have the
following two in your logs:
```
[INFO] Installing .../jclouds-karaf/feature-labs/pom.xml to
/Users/svet/.m2/repository/org/apache/jclouds/karaf/jclouds-karaf-labs/2.1.0-SNAPSHOT/jclouds-karaf-labs-2.1.0-SNAPSHOT.pom
[INFO] Installing .../jclouds-karaf/feature-labs/target/feature-labs.xml to
/Users/svet/.m2/repository/org/apache/jclouds/karaf/jclouds-karaf-labs/2.1.0-SNAPSHOT/jclouds-karaf-labs-2.1.0-SNAPSHOT-features.xml
```
Same for the non-labs feature pom.
> + <bundle
> dependency='true'>mvn:org.apache.jclouds.common/googlecloud/${jclouds.version}</bundle>
+
<bundle>mvn:org.apache.jclouds.labs/google-cloud-storage/${jclouds.version}</bundle>
+ </feature>
+
+ <feature name='jclouds-packet' description='Packet'
version='${project.version}' resolver='(obr)'>
+ <feature version='${project.version}'>jclouds-compute</feature>
+ <bundle>mvn:org.apache.jclouds.labs/packet/${jclouds.version}</bundle>
+ </feature>
+
+ <feature name='jclouds-vagrant' description='Components to access Vagrant'
version='${project.version}' resolver='(obr)'>
+ <feature version='${project.version}'>jclouds-compute</feature>
+ <bundle
dependency='true'>mvn:name.neykov/vagrant-java-bindings/${vagrant-java-bindings.version}</bundle>
+ <bundle>mvn:org.apache.jclouds.labs/vagrant/${jclouds.version}</bundle>
+ </feature>
+
+ <!-- SERVICES -->
You can remove these now that they are in feature-labs.
> + featuresService.installFeature("jclouds-rackspace-cloudfiles-us");
+ }
+
+ @Test
+ public void testServerloveZ1ManFeature() throws Exception {
+ featuresService.installFeature("jclouds-serverlove-z1-man");
+ }
+
+ @Test
+ public void testSkalicloudSdgMyFeature() throws Exception {
+ featuresService.installFeature("jclouds-skalicloud-sdg-my");
+ }
+
+ @Test
+ public void testSoftlayerFeature() throws Exception {
+ featuresService.installFeature("jclouds-softlayer");
For future updates - I believe these "install" tests can be done more
efficiently with the `verify` goal of the `maven-karaf-plugin`.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92#pullrequestreview-25492747
