demobox commented on this pull request.


> @@ -516,32 +521,27 @@ limitations under the License.
     </feature>
 
     <feature name='jclouds-cloudsigma2-hnl' description='CloudSigma v2 
Honolulu' version='${project.version}'>
-        <feature version='${project.version}'>jclouds-compute</feature>

I'm not sure what our pattern is here - for other features, we seem to be 
including _all_ transitive features, e.g.:

```
    <feature name='jclouds-rackspace-cloudservers-us' description='Rackspace 
Cloudservers US' version='${project.version}'>
        <feature version='${project.version}'>jclouds-compute</feature>
        <feature 
version='${project.version}'>jclouds-api-openstack-nova</feature>
        <feature 
version='${project.version}'>jclouds-api-rackspace-cloudidentity</feature>
<bundle>mvn:org.apache.jclouds.provider/rackspace-cloudservers-us/${jclouds.version}</bundle>
...
```

Any thoughts @nacx @iocanel?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/99#pullrequestreview-27729173

Reply via email to