nacx commented on this pull request.
Thanks @neykov! Great docs!
There is a small checkstyle violation that needs to be addressed:
https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/1713/org.apache.jclouds.labs$vagrant/violations/file/src/test/java/org/jclouds/vagrant/compute/WindowsLiveTest.java/
> @@ -103,4 +109,11 @@ public void testBoxConfig() {
assertEquals(boxConfig.getStringKey(".vm.communicator"),
Optional.of("winrm"));
assertEquals(boxConfig.getKey(VagrantConstants.KEY_VM_GUEST),
Optional.of(VagrantConstants.VM_GUEST_WINDOWS));
}
+
+ private void skipIfImageNotPresent() {
+ Image image = view.getComputeService().getImage(getImageId());
The `getImage` call is not cached (as opposed to the `listImages` one). Better
get the image in a `@Before` method just once?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/373#pullrequestreview-27785991
