nacx commented on this pull request.
Changes look good. Thanks @trevorflanagan!
Just one comment left: in builders that produce objects with non-nullable
collections and maps, we should return immutable empty objects instead of null.
Could you apply this change?
>
- public abstract Builder cpusSpeed(List<CpuSpeed> properties);
+ public abstract Builder cpuSpeeds(List<CpuSpeed> cpuSpeeds);
+
+ abstract Hypervisor autoBuild();
+
+ abstract List<Property> properties();
+
+ abstract List<DiskSpeed> diskSpeeds();
+
+ abstract List<CpuSpeed> cpuSpeeds();
+
+ public Hypervisor build() {
+ properties(properties() != null ? ImmutableList.copyOf(properties())
: null);
+ diskSpeeds(diskSpeeds() != null ? ImmutableList.copyOf(diskSpeeds())
: null);
+ cpuSpeeds(cpuSpeeds() != null ? ImmutableList.copyOf(cpuSpeeds()) :
null);
For lists not marked `@Nullable` we should return an empty list instead of null
(or mark them `@Nullable` if appropriate).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/369#pullrequestreview-28241924
