gatj98 commented on this pull request.


> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.dimensiondata.cloudcontrol.options;
+
+import com.google.common.collect.Multimap;
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
+
+import java.util.Collection;
+
+import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertTrue;
+
+@Test(groups = "unit", testName = "PaginationOptionsTest", singleThreaded = 
true)

Initially it wasn't single threaded, but push request build failed for one of 
the tests at line 81 where the size of the value collection is checked. I 
figured this was because the threads were accessing the paginationOptions field 
at the same time. 

Given it's such a quick test didn't really see the benefit of multi threading 
so I made it single threaded rather than putting 'PaginationOptions 
paginationOptions = new PaginationOptions();' into each test method and 
ditching the instance fields. Will change it though

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/377#discussion_r108030417

Reply via email to