nacx commented on this pull request.
Changes look good! Just one minor and one trivial comment left. Mind directly
squashing the commits when addressing them so I can cleanly merge the PR?
> +public class BaseAccountAwareCloudControlMockTest extends
> BaseDimensionDataCloudControlMockTest {
+
+ private boolean accountRetrieved;
+
+ @Override
+ protected void applyAdditionalServerConfig() {
+ server.enqueue(jsonResponse("/account.json"));
+ }
+
+ @BeforeMethod
+ public void reset() {
+ accountRetrieved = false;
+ }
+
+ protected Uris.UriBuilder addPageNumberToUriBuilder(Uris.UriBuilder
uriBuilder, int pageNumber) {
+
uriBuilder.addQuery(PaginationOptions.Builder.pageNumber(pageNumber).buildQueryParameters());
It's better not to use the pagination class. I'd say it would be better to
directly call `uriBuilder.addQuery("param-name", pageNumber)`, to catch any
(accidental or not) issue if the pagination options class is changed in the
future.
> }
@AfterMethod(alwaysRun = true)
- public void stop() throws IOException {
+ public void stop(ITestContext testContext) throws Exception {
Is this parameter actually needed?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/377#pullrequestreview-29183161
