nacx approved this pull request.
LGTM. Thanks @andrewgaul!
> +import com.google.inject.name.Named;
+
+public final class GoogleCloudStorageBlobRequestSigner implements
BlobRequestSigner {
+ private static final int DEFAULT_EXPIRY_SECONDS = 15 * 60;
+ private static final URI STORAGE_URL =
URI.create("http://storage.googleapis.com/";);
+
+ private final Supplier<Credentials> creds;
+ private final Supplier<PrivateKey> privateKey;
+ private final Provider<Long> timestamp;
+ private final HttpUtils utils;
+
+ private final BlobToHttpGetOptions toGetOptions = new
BlobToHttpGetOptions();
+
+ @Resource
+ @Named(Constants.LOGGER_SIGNATURE)
+ Logger signatureLog = Logger.NULL;
Better make it protected?
> @@ -29,5 +33,12 @@
protected void configure() {
bind(ConsistencyModel.class).toInstance(ConsistencyModel.EVENTUAL);
bind(BlobStore.class).to(GoogleCloudStorageBlobStore.class).in(Scopes.SINGLETON);
+
bind(BlobRequestSigner.class).to(GoogleCloudStorageBlobRequestSigner.class);
+ }
+
+ @Provides
+ @TimeStamp
+ protected Long unixEpochTimestamp() {
Better declare it final to make explicit the fact that Guice does not allow to
override provider methods.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/175#pullrequestreview-33688590
