nacx commented on this pull request.


>  
-      PublicIPAddressProperties properties = 
PublicIPAddressProperties.builder().publicIPAllocationMethod("Static")
-              .idleTimeoutInMinutes(4).build();
+      for (IpOptions ipConfig : publicIpsFirst(options.getIpOptions())) {

Not sure a function would be that appropriate here. This method (as a private 
method) depends a lot on the current context. It not only depends on the ip 
configurations, but also on other template options such as the security groups 
and the name of the node. I think it makes sense here as a private method.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/386#discussion_r113631459

Reply via email to