Thanks, @gnodet! Changes LGTM :)

I've built the branch, downloaded Karaf 4.0.9 and installed the jclouds 
features:

```bash
karaf@root()> feature:repo-add 
mvn:org.apache.jclouds.karaf/jclouds-karaf/2.1.0-SNAPSHOT/xml/features
Adding feature url 
mvn:org.apache.jclouds.karaf/jclouds-karaf/2.1.0-SNAPSHOT/xml/features
karaf@root()> feature:repo-add 
mvn:org.apache.jclouds.karaf/jclouds-karaf-labs/2.1.0-SNAPSHOT/xml/features
Adding feature url 
mvn:org.apache.jclouds.karaf/jclouds-karaf-labs/2.1.0-SNAPSHOT/xml/features
karaf@root()> feature:install jclouds-compute jclouds-services jclouds-commands 
jclouds-digitalocean2
karaf@root()> feature:list -i
Name                  | Version        | Required | State    | Repository       
      | Description
-----------------------------------------------------------------------------------------------------------------------------------------
jclouds-guice         | 2.1.0.SNAPSHOT |          | Started  | 
jclouds-2.1.0-SNAPSHOT | jclouds - Google Guice
jclouds               | 2.1.0.SNAPSHOT |          | Started  | 
jclouds-2.1.0-SNAPSHOT | jclouds
jclouds-blobstore     | 2.1.0.SNAPSHOT |          | Started  | 
jclouds-2.1.0-SNAPSHOT | jclouds - blobstore
jclouds-compute       | 2.1.0.SNAPSHOT | x        | Started  | 
jclouds-2.1.0-SNAPSHOT | jclouds - compute
jclouds-scriptbuilder | 2.1.0.SNAPSHOT |          | Started  | 
jclouds-2.1.0-SNAPSHOT | jclouds - scriptbuilder
jclouds-api-oauth     | 2.1.0.SNAPSHOT |          | Started  | 
jclouds-2.1.0-SNAPSHOT | jclouds - API - OAuth
jclouds-api-sts       | 2.1.0.SNAPSHOT |          | Started  | 
jclouds-2.1.0-SNAPSHOT | jclouds - API - STS
jclouds-digitalocean2 | 2.1.0.SNAPSHOT | x        | Started  | 
jclouds-2.1.0-SNAPSHOT | Components to access DigitalOcean v2
jclouds-services      | 2.1.0.SNAPSHOT | x        | Started  | 
jclouds-2.1.0-SNAPSHOT | OSGi Service Factories for jclouds
jclouds-commands      | 2.1.0.SNAPSHOT | x        | Started  | 
jclouds-2.1.0-SNAPSHOT | Karaf Commands for jclouds
aries-proxy           | 4.0.9          |          | Started  | standard-4.0.9   
      | Aries Proxy
aries-blueprint       | 4.0.9          | x        | Started  | standard-4.0.9   
      | Aries Blueprint
feature               | 4.0.9          | x        | Started  | standard-4.0.9   
      | Features Support
shell                 | 4.0.9          | x        | Started  | standard-4.0.9   
      | Karaf Shell
shell-compat          | 4.0.9          | x        | Started  | standard-4.0.9   
      | Karaf Shell Compatibility
deployer              | 4.0.9          | x        | Started  | standard-4.0.9   
      | Karaf Deployer
bundle                | 4.0.9          | x        | Started  | standard-4.0.9   
      | Provide Bundle support
config                | 4.0.9          | x        | Started  | standard-4.0.9   
      | Provide OSGi ConfigAdmin support
diagnostic            | 4.0.9          | x        | Started  | standard-4.0.9   
      | Provide Diagnostic support
instance              | 4.0.9          | x        | Started  | standard-4.0.9   
      | Provide Instance support
jaas                  | 4.0.9          | x        | Started  | standard-4.0.9   
      | Provide JAAS support
log                   | 4.0.9          | x        | Started  | standard-4.0.9   
      | Provide Log support
package               | 4.0.9          | x        | Started  | standard-4.0.9   
      | Package commands and mbeans
service               | 4.0.9          | x        | Started  | standard-4.0.9   
      | Provide Service support
system                | 4.0.9          | x        | Started  | standard-4.0.9   
      | Provide System support
kar                   | 4.0.9          | x        | Started  | standard-4.0.9   
      | Provide KAR (KARaf archive) support
ssh                   | 4.0.9          | x        | Started  | standard-4.0.9   
      | Provide a SSHd server on Karaf
management            | 4.0.9          | x        | Started  | standard-4.0.9   
      | Provide a JMX MBeanServer and a set of MBeans in
wrap                  | 0.0.0          | x        | Started  | standard-4.0.9   
      | Wrap URL handler
```

Everything looks fine but the `jclouds:` commands don't seem to be available. 
(If you want to try it you should be able to invoke 
`jclouds:compute-service-list` without needing to register any particular cloud 
provider). Is this something related to the need to migrate the commands to the 
new API, or is there any configuration we can apply to make them available 
again?

Thanks again for your support! 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/102#issuecomment-300747357

Reply via email to