andreaturli commented on this pull request.
thanks @geomacy -- looks quite useful.
some minor comments + I'd like to test it myself a bit more
> + @AutoValue.Builder
+ public abstract static class Builder {
+ public abstract Builder destinationCidrBlock(String
destinationCidrBlock);
+
+ public abstract Builder gatewayId(String gatewayId);
+
+ public abstract Builder state(RouteState state);
+
+ public abstract Builder origin(String origin);
+
+ @Nullable abstract String destinationCidrBlock();
+ @Nullable abstract String gatewayId();
+ @Nullable abstract RouteState state();
+ @Nullable abstract String origin();
+
+ abstract Route autoBuild();
do you need autobuild here or `abstract Route build();` would do it?
> + return new AutoValue_RouteTableAssociation.Builder();
+ }
+
+ @AutoValue.Builder
+ public abstract static class Builder {
+ public abstract Builder id(String id);
+ public abstract Builder routeTableId(String routeTableId);
+ public abstract Builder subnetId(String subnetId);
+ public abstract Builder main(Boolean main);
+
+ @Nullable abstract String id();
+ @Nullable abstract String routeTableId();
+ @Nullable abstract String subnetId();
+ @Nullable abstract Boolean main();
+
+ abstract RouteTableAssociation autoBuild();
same comment as `Route` class
> @@ -40,17 +40,17 @@
/**
* The subnet is not yet available for use.
*/
- PENDING, UNRECOGNIZED;
why unrecognized is not needed?
> @@ -60,18 +60,16 @@ public static State fromValue(String v) {
*/
DEFAULT,
DEDICATED,
- HOST,
- UNRECOGNIZED;
why are you removing it?
> + * (if needed):
+ * <p/>
+ * <code>
+ * import static org.jclouds.ec2.options.RouteTableOptions.Builder.*
+ * <p/>
+ * EC2Api connection = // get connection
+ * RouteTable table =
connection.getRouteTableApi().get().createRouteTable(vpcId, dryRun());
+ * <code>
+ *
+ * @see <a
+ *
href="http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateRouteTable.html";
+ * />
+ */
+public class RouteTableOptions extends BaseEC2RequestOptions {
+
+ public static final RouteTableOptions NONE = new RouteTableOptions();
sometimes we had issue with this pattern, I remember an interesting bug with
`dockertemplateoptions`, is it useful? I'd consider removing it
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1100#pullrequestreview-38515785
