nacx requested changes on this pull request.
> @@ -74,7 +74,11 @@ static boolean is64Bit(int architecture) {
return tryFind(asList(OsFamily.values()), new Predicate<OsFamily>() {
@Override
public boolean apply(OsFamily input) {
- return
osFamily.toLowerCase().contains(input.value().toLowerCase());
+ if (osFamily != null) {
`osFamily` is the input parameter of the function. There's no need to do the
same redundant check in each iteration. Remove this and directly return absent
at the beginning if the input parameter is null. Same for the other function.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/395#pullrequestreview-40858908
