geomacy commented on this pull request.
> @@ -95,6 +101,7 @@ public Boolean apply(String id) {
}
boolean serverDeleted =
novaApi.getServerApi(regionAndId.getRegion()).delete(regionAndId.getId());
+ checkState(nodeTerminatedPredicate.apply(id), "server was not destroyed
in the configured timeout");
No real opinion on that to be honest! I would say though, that if the
`cleanupServer.apply()` is being invoked as per the link above (inside
`cleanUpIncidentalResourcesOfDeadNodes`), then you probably want to avoid the
exception here, as otherwise the first exception when iterating over
`deadNodes` will prevent any remaining nodes even being attempted.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#discussion_r126630432
