[
https://issues.apache.org/jira/browse/JCLOUDS-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141808#comment-16141808
]
ASF GitHub Bot commented on JCLOUDS-1332:
-----------------------------------------
GitHub user andreaturli opened a pull request:
https://github.com/apache/brooklyn-server/pull/805
Modify jcloudsLocation.releaseNode
Workaround waiting for a fix for
https://issues.apache.org/jira/browse/JCLOUDS-1332
Uses `destroyNodesMatchingId` instead of `destroyNode` as it consistently
invokes `cleanUpIncidentalResourcesOfDeadNodes`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andreaturli/brooklyn-server
fix/jclouds-location-releaseNode
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/805.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #805
----
commit 53c0d4408270a2aafab803c8e8ff5300f3fa38e9
Author: Andrea Turli <andrea.tu...@gmail.com>
Date: 2017-08-25T15:58:45Z
Modify jcloudsLocation.releaseNode
- from destroyNode to destroyNodesMatchingId as it calls consistently
cleanUpIncidentalResourcesOfDeadNodes
----
> BaseComputeService.destroyNodesMatching and BaseComputeService.destroyNode
> different behavior
> ---------------------------------------------------------------------------------------------
>
> Key: JCLOUDS-1332
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1332
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-compute
> Affects Versions: 2.0.1, 2.0.2
> Reporter: Andrea Turli
> Assignee: Andrea Turli
> Priority: Critical
> Fix For: 2.1.0, 2.0.3
>
>
> DestroyNode doesn't clean up incidental resources as the destroyNodesMatching
> does.
> In fact, nodeTerminate.apply(node) has a side-effect and set node=null
> Potential fixes:
> - return `md` instead of node.get
> or
> - TrueIfNullOrDeletedRefreshAndDoubleCheckOnFalse predicate to return true
> when `refreshOrNull` return null
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
