[
https://issues.apache.org/jira/browse/JCLOUDS-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142829#comment-16142829
]
Tim Peierls edited comment on JCLOUDS-1225 at 8/27/17 2:24 AM:
---------------------------------------------------------------
Created issue JCLOUDS-1334, made fix in local branch, and will try to create
pull request from that.
The other part of my comment was that I wasn't sure whether *all* of these
replacements are supported in Guava 18:
find -name *.java | xargs sed -i
's/sameThreadExecutor/newDirectExecutorService/g'
find -name *.java | xargs sed -i 's/Objects.[Tt]oStringHelper/More&/g'
find -name *.java | xargs sed -i 's/Objects.firstNonNull/More&/g'
find -name *.java | xargs sed -i 's/^(import
com.google.common.base.)(Objects.*)/\1More\2\n\1\2/g'
Could be that they are, just not sure.
was (Author: tpeierls):
Created issue JCLOUDS-1334
[https://issues.apache.org/jira/browse/JCLOUDS-1334], made fix in local branch,
and will try to create pull request from that.
The other part of my comment was that I wasn't sure whether *all* of these
replacements are supported in Guava 18:
find -name *.java | xargs sed -i
's/sameThreadExecutor/newDirectExecutorService/g'
find -name *.java | xargs sed -i 's/Objects.[Tt]oStringHelper/More&/g'
find -name *.java | xargs sed -i 's/Objects.firstNonNull/More&/g'
find -name *.java | xargs sed -i 's/^(import
com.google.common.base.)(Objects.*)/\1More\2\n\1\2/g'
Could be that they are, just not sure.
> Guava 21 compatibility
> ----------------------
>
> Key: JCLOUDS-1225
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1225
> Project: jclouds
> Issue Type: Improvement
> Components: jclouds-core
> Affects Versions: 2.0.0
> Reporter: Ian Springer
> Assignee: Andrew Gaul
> Labels: guava
> Fix For: 2.1.0
>
>
> The below classes use com.google.common.base.Objects.ToStringHelper, which
> has been deprecated since Guava 18, and has been removed in Guava 21. This
> makes it impossible to use jclouds in a project using Guava 21. Please either
> upgrade to Guava 18+ and switch to using
> com.google.common.base.MoreObjects.ToStringHelper, or drop the usage of
> ToStringHelper altogether. This will allow my project to upgrade to Guava 21
> without having to use a fork of jclouds.
> * org/jclouds/apis/internal/BaseApiMetadata.java
> * org/jclouds/domain/internal/LocationImpl.java
> * org/jclouds/domain/internal/MutableResourceMetadataImpl.java
> * org/jclouds/domain/internal/ResourceMetadataImpl.java
> * org/jclouds/http/HttpMessage.java
> * org/jclouds/http/HttpRequest.java
> * org/jclouds/http/HttpResponse.java
> * org/jclouds/internal/BaseView.java
> * org/jclouds/providers/internal/BaseProviderMetadata.java
> * org/jclouds/reflect/InvocationSuccess.java
> * org/jclouds/rest/internal/BaseHttpApiMetadata.java
> * org/jclouds/rest/suppliers/URIFromStringSupplier.java
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
