gaul requested changes on this pull request.
> }
// Mac OS X HFS+ does not support UserDefinedFileAttributeView:
// https://bugs.openjdk.java.net/browse/JDK-8030048
@Override
protected void validateMetadata(BlobMetadata metadata) throws IOException {
- if (!isMacOSX()) {
- super.validateMetadata(metadata);
- }
+ checkExtendedAttributesSupport();
This is what I mentioned in my previous review -- this will cause a test which
checks many metadata, including non-xattr, to skip. We should only skip full
tests.
> @Override
protected void checkUserMetadata(Map<String, String> userMetadata1,
Map<String, String> userMetadata2) {
- if (!isMacOSX()) {
- super.checkUserMetadata(userMetadata1, userMetadata2);
- }
+ checkExtendedAttributesSupport();
+ super.checkUserMetadata(userMetadata1, userMetadata2);
+ }
+
+ /*
+ * Java on OS X does not support extended attributes, which the filesystem
+ * backend uses to implement storage tiers
+ */
+ @Override
+ protected void testPutBlobTierHelper(Tier tier, PutOptions options) throws
Exception {
+ checkExtendedAttributesSupport();
+ super.testPutBlobTierHelper(tier, options);
This correctly skips.
> }
@Override
public void testSetBlobAccess() throws Exception {
throw new SkipException("filesystem does not support anonymous access");
}
+
+ private void checkExtendedAttributesSupport() {
+ if (isMacOSX()) {
+ throw new SkipException("filesystem does not support extended
attributes on Mac OSX");
I don't think this adds anything an prevents `grep` from finding tests we skip,
part of the expanded scope of this pull request.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1150#pullrequestreview-71534715
