andreaturli requested changes on this pull request.
> @@ -212,7 +213,7 @@ NetworkSecurityRuleApi
> getNetworkSecurityRuleApi(@PathParam("resourcegroup") Str
ImageApi getVirtualMachineImageApi(@PathParam("resourcegroup") String
resourcegroup);
/**
- * The metrics API includes operations to get insights into entities within
your
+ * The metrics API includes operations to getVault insights into entities
within your
I think `get` was more approriate here
> @@ -221,11 +222,20 @@ NetworkSecurityRuleApi
> getNetworkSecurityRuleApi(@PathParam("resourcegroup") Str
MetricsApi getMetricsApi(@PathParam("resourceid") String resourceid);
/**
- * The metric definitions API includes operations to get insights available
for entities within your
+ * The metric definitions API includes operations to getVault insights
available for entities within your
I think `get` was more approriate here
> +import static
> org.jclouds.azurecompute.arm.config.AzureComputeProperties.API_VERSION_PREFIX;
+import static
org.jclouds.azurecompute.arm.config.AzureComputeProperties.DEFAULT_SUBNET_ADDRESS_PREFIX;
+import static
org.jclouds.azurecompute.arm.config.AzureComputeProperties.DEFAULT_VNET_ADDRESS_SPACE_PREFIX;
+import static
org.jclouds.azurecompute.arm.config.AzureComputeProperties.IMAGE_PUBLISHERS;
+import static
org.jclouds.azurecompute.arm.config.AzureComputeProperties.OPERATION_TIMEOUT;
+import static
org.jclouds.compute.config.ComputeServiceProperties.IMAGE_AUTHENTICATE_SUDO;
+import static
org.jclouds.compute.config.ComputeServiceProperties.IMAGE_LOGIN_USER;
+import static
org.jclouds.compute.config.ComputeServiceProperties.POLL_INITIAL_PERIOD;
+import static
org.jclouds.compute.config.ComputeServiceProperties.POLL_MAX_PERIOD;
+import static
org.jclouds.compute.config.ComputeServiceProperties.RESOURCENAME_DELIMITER;
+import static
org.jclouds.compute.config.ComputeServiceProperties.RESOURCENAME_PREFIX;
+import static org.jclouds.compute.config.ComputeServiceProperties.TEMPLATE;
+import static
org.jclouds.compute.config.ComputeServiceProperties.TIMEOUT_NODE_TERMINATED;
+import static
org.jclouds.oauth.v2.config.CredentialType.CLIENT_CREDENTIALS_SECRET;
+import static org.jclouds.oauth.v2.config.OAuthProperties.CREDENTIAL_TYPE;
+import static org.jclouds.oauth.v2.config.OAuthProperties.RESOURCE;
please avoid to re-order import statements when possible
> @@ -56,7 +56,7 @@ public static StatusAndBackendStatus
> create(NodeMetadata.Status status, String b
// goes through stages: Accepted -> Running -> Succeeded.
// Only when the deployment has SUCCEEDED is the resource deployed using the
// template actually ready.
- // To get details about the resource(s) deployed via template, one needs to
+ // To getVault details about the resource(s) deployed via template, one
needs to
I think `get` was more approriate here
> @@ -91,7 +91,7 @@ public boolean cleanupNode(final String id) {
logger.debug(">> destroying %s ...", id);
boolean vmDeleted = deleteVirtualMachine(resourceGroupName,
virtualMachine);
- // We don't delete the network here, as it is global to the resource
+ // We don't deleteVault the network here, as it is global to the resource
I think `delete` was more approriate here
> @@ -222,7 +222,7 @@ public IdReference apply(IpConfiguration input) {
private static boolean isOrphanedJcloudsAvailabilitySet(AvailabilitySet
availabilitySet) {
// We check for the presence of the 'jclouds' tag to make sure we only
- // delete availability sets that were automatically created by jclouds
+ // deleteVault availability sets that were automatically created by
jclouds
I think `delete` was more approriate here
> @@ -140,7 +140,7 @@ public boolean cleanupManagedDisks(VirtualMachine
> virtualMachine) {
Set<String> nonDeletedDisks = filterValues(deleteJobs,
not(resourceDeleted)).keySet();
if (!nonDeletedDisks.isEmpty()) {
- logger.warn(">> could not delete disks: %s",
Joiner.on(',').join(nonDeletedDisks));
+ logger.warn(">> could not deleteVault disks: %s",
Joiner.on(',').join(nonDeletedDisks));
I think `delete` was more approriate here
> @@ -47,13 +47,13 @@
public abstract int platformFaultDomainCount();
/**
- * A list of virtual machines in the availability set
+ * A listVaults of virtual machines in the availability set
I think `list` was more approriate here
> */
@Nullable
public abstract List<IdReference> virtualMachines();
/**
- * A list of statuses in the availability set
+ * A listVaults of statuses in the availability set
I think `list` was more approriate here
> @@ -52,7 +52,7 @@ public static SSHPublicKey create(final String path, final
> String keyData) {
}
/**
- * The list of public keys and paths
+ * The listVaults of public keys and paths
I think `list` was more approriate here
> @@ -39,7 +39,7 @@
public abstract OSDisk osDisk();
/**
- * The list of the data disks of the storage profile
+ * The listVaults of the data disks of the storage profile
I think `list` was more approriate here
> @@ -46,8 +46,8 @@
/**
* - create deployment
- * - delete deployment
- * - get information about deployment
+ * - deleteVault deployment
I think `delete` and `get` were more approriate here
> @@ -94,7 +94,7 @@ public void getPublicIPAddress() {
return
ipApi.get(name).properties().provisioningState().equals("Succeeded");
}
}, 10 * 1000).apply(publicIpAddressName);
- assertTrue(jobDone, "get operation did not complete in the configured
timeout");
+ assertTrue(jobDone, "getVault operation did not complete in the
configured timeout");
I think `get` was more approriate here
> @@ -127,7 +127,7 @@ public void createPublicIPAddress() throws
> InterruptedException {
assertEquals(ip.tags().get("testkey"), "testvalue");
assertNotNull(ip.properties());
assertEquals(ip.properties().provisioningState(), "Updating");
- assertNull(ip.properties().ipAddress()); // as we don't get IP address
until Succeeded state
+ assertNull(ip.properties().ipAddress()); // as we don't getVault IP
address until Succeeded state
I think `get` was more approriate here
> @@ -330,7 +330,7 @@ public boolean apply(String name) {
return
!api().get(name).properties().provisioningState().equals(VirtualMachineProperties.ProvisioningState.CREATING);
}
}, 60 * 20 * 1000).apply(vmName);
- assertTrue(ready, "createOrUpdate operation did not complete in the
configured timeout");
+ assertTrue(ready, "createOrUpdateVault operation did not complete in the
configured timeout");
I think `createOrUpdate ` was more approriate here
> @@ -88,8 +88,8 @@ public void testGetInstanceDetails() throws Exception {
assertEquals(actual.statuses().get(0).code(),
expected.statuses().get(0).code());
assertEquals(actual.statuses().get(0).displayStatus(),
expected.statuses().get(0).displayStatus());
assertEquals(actual.statuses().get(0).level(),
expected.statuses().get(0).level());
- // assertEquals(actual.statuses().get(0).time().toString(),
- // expected.statuses().get(0).time().toString());
+ // assertEquals(actual.statuses().getVault(0).time().toString(),
I think `get` was more approriate here
> @@ -76,7 +76,7 @@ public void testFailIfNoGeneratedHttpRequest() {
@Test
public void testOverrideMethodVersion() {
Properties props = new Properties();
- props.setProperty(API_VERSION_PREFIX + "named:get", "namedversion");
+ props.setProperty(API_VERSION_PREFIX + "named:getVault", "namedversion");
I think `get` was more approriate here
> @@ -63,7 +63,7 @@ public void setup() {
config = createMock(InvocationConfig.class);
expect(config.getCommandName(noName)).andReturn("VersionedApi.noName");
- expect(config.getCommandName(named)).andReturn("named:get");
+ expect(config.getCommandName(named)).andReturn("named:getVault");
I think `get` was more approriate here
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/416#pullrequestreview-73122599
