nacx commented on this pull request.
> + OsImageToImage(@Memoized final Supplier<Set<Location>> locations,
+ Function<String, OsFamily> imageDescriptionToOsFamily) {
+ this.locations = locations;
+ this.imageDescriptionToOsFamily = imageDescriptionToOsFamily;
+ }
+
+ @Override
+ public Image apply(OsImage input) {
+
+ OsFamily osFamily =
imageDescriptionToOsFamily.apply(input.description());
+ String osVersion = parseVersion(input.description());
+
+ OperatingSystem os =
OperatingSystem.builder().name(input.name()).description(input.description())
+
.family(osFamily).version(osVersion).is64Bit(is64bit(input)).build();
+
+ return new
ImageBuilder().id(input.id()).name(input.name()).description(input.description())
I mean, you should think about it this way: calling
`ComputeService.getImage(id)` with this ID will succeed? Or should the ID
carry/encode additional info?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/421#discussion_r153417324
