andreaturli approved this pull request.
only a minor comment, lgtm
thanks @nacx
> + filter(transform(contentEntries,
> deserializeSerialOutput(json)), notNull()), HasEncryptedPassword)
+ .transform(ExtractEncryptedPassword);
+
+ if (retrievedPassword.isPresent()) {
+ encryptedPassword.set(retrievedPassword.get());
+ }
+
+ return retrievedPassword.isPresent();
+ }
+ // Notice that timeoutDuration should be less than EXPIRE_DURATION
+ }, 10 * 60, 30, TimeUnit.SECONDS).apply(instance.get());
+
+ if (passwordRetrieved) {
+ return decryptPassword(encryptedPassword.get(), keys);
+ } else {
+ throw new IllegalStateException("Did not find the encrypted
password in the serial port output");
should we also logged here?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1163#pullrequestreview-79918328
