nacx commented on this pull request.
> + }
+ }
+
+ private void attemptDeleteNatRule(final String serverId, final NetworkApi
networkApi, final NatRule natRule) {
+ try {
+ if (natRule.state().isNormal()) {
+ networkApi.deleteNatRule(natRule.id());
+ } else {
+ logger.warn(format("Server(%s) has an associated NatRule(%s) that
was not deleted as it was in state(%s).",
+ serverId, natRule.id(), natRule.state()));
+ }
+ } catch (Throwable t) {
+ logger.warn(
+ format("Failed to delete NatRule(%s) associated with
Server(%s). Due to - (%s)", natRule.id(), serverId,
+ t.getMessage()));
+ }
Better pass the `Throwable` as the first parameter to the logger to have the
complete stacktrace logged. Often just the exception message does not give
enough contex.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/422#pullrequestreview-80893593
