trevorflanagan commented on this pull request.
> + this.nodeNamingConvention = checkNotNull(namingConvention,
> "namingConvention").createWithoutPrefix();
+ this.locations = checkNotNull(locations, "locations");
+ this.baseImageToImage = checkNotNull(baseImageToImage,
"baseImageToImage");
+ this.baseImageToHardware = checkNotNull(baseImageToHardware,
"osImageToHardware");
+ this.credentialStore = checkNotNull(credentialStore, "credentialStore
cannot be null");
+ this.api = checkNotNull(api, "api cannot be null");
+ }
+
+ @Override
+ public NodeMetadata apply(final ServerWithExternalIp serverWithExternalIp) {
+ NodeMetadataBuilder builder = new NodeMetadataBuilder();
+ Server server = serverWithExternalIp.server();
+ builder.ids(server.id());
+ builder.name(server.name());
+ builder.hostname(serverWithExternalIp.server().description());
+ if (server.datacenterId() != null) {
Should not be null. Our xsd has it as a required attribute:
`<xs:attribute name="datacenterId" type="xs:string" use="required"/>`
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/428#discussion_r158450187
