nacx commented on this pull request.
Just one comment. Apart from that looks good.
Could you share the results of the live tests for the Nova and Neutron SG
extensions?
> + if (region == null) {
+ return ImmutableSet.of();
+ }
+ return
getSecurityGroupApi(region).listSecurityGroups().concat().transform(neutronSecurityGroupToSecurityGroup.create(location)).toSet();
+ }
+
+ @Override
+ public Set<SecurityGroup> listSecurityGroupsForNode(String id) {
+ RegionAndId regionAndId = RegionAndId.fromSlashEncoded(checkNotNull(id,
"id"));
+ String region = regionAndId.getRegion();
+ String instanceId = regionAndId.getId();
+
+ Optional<? extends ServerWithSecurityGroupsApi> serverApi =
api.getServerWithSecurityGroupsApi(region);
+ SecurityGroupApi securityGroupApi = getSecurityGroupApi(region);
+
+ ServerWithSecurityGroups instance = serverApi.get().get(instanceId);
This is not used later. You're always returning all security groups.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1175#pullrequestreview-92514310
