375 classes need be modified....
```
$ grep -l "import com.google.common.base.Predicate;" -r * | wc -l
375
```
I think I will avoid using jclouds and maybe remove from my package. This is
insanity.... It also is not required in my env, so I am not sure why any of
this is even necessary. This seems like legacy incompatibility....
As a project you all need to make some hard decisions. I maintain hundreds,
over a thousand Java packages. This is one of the only with such legacy issues.
The other is horrible lombok.... I would really recommend telling those with
legacy needs to use older jclouds. For any newer releases really need to move
to newer stuff. Or you will continue to be plagued and held back by odd issues
like this. Which take considerable time to resolve.
I think I am about done here... The change seems pretty massive, and I feel
like other issues in future. CI failing on overrides, which at some point would
need to be in there. But why it cannot find the Guava implementation of
```test```. That to me seems like some legacy issue.
Under 1.8 it says it failed, but seems it compiled...
```bash
mvn clean install -Dguava.version=21.0 -pl :jclouds-core -am
-Dmaven.compile.source=1.8 -Dmaven.compile.target=1.8 -Dmaven.test.skip=true
```
```bash
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ jclouds-core
---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 358 source files to /projects/jclouds/core/target/classes
/projects/jclouds/core/src/main/java/org/jclouds/json/internal/NamingStrategies.java:264:
warning: [cast] redundant cast to Predicate<Class<? extends Annotation>>
}).anyMatch((Predicate<Class<? extends Annotation>>)
in(markers));
^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 warning
[INFO]
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @
jclouds-core ---
[INFO] Not copying test resources
[INFO]
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @
jclouds-core ---
[INFO] Not compiling test sources
[INFO]
[INFO] --- maven-surefire-plugin:2.17:test (default-test) @ jclouds-core ---
[INFO] Tests are skipped.
[INFO]
[INFO] --- animal-sniffer-maven-plugin:1.11:check (default) @ jclouds-core ---
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java16:1.1
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache jclouds Project ............................. SUCCESS [ 3.787 s]
[INFO] jclouds shared Maven resources ..................... SUCCESS [ 1.963 s]
[INFO] jclouds Components Core ............................ FAILURE [ 6.262 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13.459 s
[INFO] Finished at: 2018-02-16T13:36:46-05:00
[INFO] Final Memory: 81M/509M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.codehaus.mojo:animal-sniffer-maven-plugin:1.11:check (default) on project
jclouds-core: Execution default of goal
org.codehaus.mojo:animal-sniffer-maven-plugin:1.11:check failed.:
IllegalArgumentException -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :jclouds-core
```
Without the source/target I get different failures....
```bash
[INFO] Compiling 358 source files to /projects/jclouds/core/target/classes
/projects/jclouds/core/src/main/java/org/jclouds/json/internal/NamingStrategies.java:72:
error: <anonymous org.jclouds.json.internal.NamingStrategies$NameExtractor$1>
is not abstract and does not override abstract method test(Annotation) in
Predicate
this.predicate = new Predicate<Annotation>() {
^
/projects/jclouds/core/src/main/java/org/jclouds/json/internal/NamingStrategies.java:189:
error: <anonymous
org.jclouds.json.internal.NamingStrategies$AnnotationFieldNamingStrategy$1> is
not abstract and does not override abstract method test(Field) in Predicate
Iterable<Field> fields = filter(declaredFields, new
Predicate<Field>() {
^
/projects/jclouds/core/src/main/java/org/jclouds/json/internal/NamingStrategies.java:257:
error: <anonymous
org.jclouds.json.internal.NamingStrategies$AnnotationConstructorNamingStrategy$1>
is not abstract and does not override abstract method test(Invokable<?,?>) in
Predicate
return new Predicate<Invokable<?, ?>>() {
^
/projects/jclouds/core/src/main/java/org/jclouds/json/internal/NamingStrategies.java:264:
warning: [cast] redundant cast to Predicate<Class<? extends Annotation>>
}).anyMatch((Predicate<Class<? extends Annotation>>)
in(markers));
^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
3 errors
1 warning
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache jclouds Project ............................. SUCCESS [ 3.789 s]
[INFO] jclouds shared Maven resources ..................... SUCCESS [ 1.798 s]
[INFO] jclouds Components Core ............................ FAILURE [ 4.468 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11.437 s
[INFO] Finished at: 2018-02-16T13:40:15-05:00
[INFO] Final Memory: 79M/470M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on
project jclouds-core: Compilation failure -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :jclouds-core
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1180#issuecomment-366322580
