demobox commented on this pull request.
Curious whether we need to extend the test coverage a bit here?
> @@ -103,7 +103,7 @@ public void simpleRootTestWithSudoPassword() {
expect(sshClient.getUsername()).andReturn("tester");
expect(sshClient.getHostAddress()).andReturn("somewhere.example.com");
expect(
- sshClient.exec("sudo -S sh <<'RUN_SCRIPT_AS_ROOT_SSH'\n" +
"testpassword!\n" + "echo $USER\n"
+ sshClient.exec("sudo -S sh <<'RUN_SCRIPT_AS_ROOT_SSH'\n" +
"'testpassword!'\n" + "echo $USER\n"
Would it make sense to modify this test so that it actually reflects the
problem we're trying to fix (e.g. space in the password)? Also, would it be
worth adding a test for the additional code path (see comment above)?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1205#pullrequestreview-119628362
