andreaturli approved this pull request.
lgtm, some minor changes
> @@ -138,7 +138,7 @@ public void deleteAvailabilitySet() throws
> InterruptedException {
assertSent(server, "DELETE", path);
}
- public void deleteSubnetResourceDoesNotExist() throws InterruptedException {
+ public void deleteAvailabilitySetDoesNotExist() throws InterruptedException
{
thanks for fixing it!
> + // Make sure the resource is fully provisioned before deleting it
+ waitUntilAvailable(name);
+ URI uri = api().delete(name);
+ assertResourceDeleted(uri);
+ }
+
+ private LocalNetworkGatewayApi api() {
+ return api.getLocalNetworkGatewayApi(resourceGroupName);
+ }
+
+ private boolean waitUntilAvailable(final String name) {
+ return resourceAvailable.apply(new Supplier<Provisionable>() {
+ @Override
+ public Provisionable get() {
+ LocalNetworkGateway gw = api().get(name);
+ return gw == null ? null : gw.properties();
why not using `provisioningState` ?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1216#pullrequestreview-128105598
