* Field 'primary' was missing in NetworkInterfaceCardProperties
* Field 'primary' was misplaced in IpConfiguration instead of 
IpConfigurationProperties

This causes problems when using the provider to configure multiple IPs per NIC 
and multiple NICs per VirtualMachine


Check 
https://docs.microsoft.com/en-us/rest/api/virtualnetwork/networkinterfaces/get#networkinterface
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1217

-- Commit Summary --

  * Fixes/adds fields primary for NetworkInterfaceCardProperties and misplaced 
in IpConfiguration

-- File Changes --

    M 
providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/IpConfiguration.java
 (13)
    M 
providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/IpConfigurationProperties.java
 (22)
    M 
providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/NetworkInterfaceCardProperties.java
 (19)
    M 
providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/NetworkInterfaceCardApiLiveTest.java
 (12)
    M 
providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/NetworkInterfaceCardApiMockTest.java
 (39)
    M 
providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/VirtualMachineApiLiveTest.java
 (18)
    M 
providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/VirtualMachineScaleSetApiLiveTest.java
 (32)
    M 
providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/VirtualMachineScaleSetApiMockTest.java
 (31)
    M 
providers/azurecompute-arm/src/test/resources/createnetworkinterfacecard.json 
(47)
    M 
providers/azurecompute-arm/src/test/resources/getnetworkinterfacecard.json (3)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1217.patch
https://github.com/jclouds/jclouds/pull/1217.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1217

Reply via email to