danielestevez commented on this pull request.
> @SelectJson("value")
@GET
@Fallback(EmptyListOnNotFoundOr404.class)
List<NetworkInterfaceCard> list();
+ @Named("networkinterfacecard:list_all")
+ @Path("/providers/Microsoft.Network/networkInterfaces")
+ @SelectJson("value")
+ @GET
+ @Fallback(EmptyListOnNotFoundOr404.class)
+ List<NetworkInterfaceCard> listAll();
Been thinking about this one... i like *listAll* since the path already has the
subscription and requires no resourcegroup, so *listAll* is (obviously?)
retrieving all the IPs in subscription.
However this led me to notice a bigger problem: to retrieve all Ips in
subscription you're now required to provide a resourcegroupname just to get the
reference this API and this makes no sense
https://github.com/danielestevez/jclouds/blob/00b6697d096b54a1f4dc6cbb6a308f91cb0728fc/providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/AzureComputeApi.java#L118
I think we should remove the required *@PathParam("resourcegroup") String
resourcegroup* in this case, but it looks like a big change... see any problem
with this?
Same applies to the publicIpAddressApi
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1225#discussion_r201356587
