I did try running `AWSS3ClientLiveTest` with the arguments you mention, and it 
did not work, as noted in the PR description. Of course the failure messages 
were pretty opaque for security reasons. Noting that these parameters are 
identical to that used by `ContextBuilder` is not particularly helpful to me 
since our tests do not require such keys to be passed in explicitly—the code 
picks up `~/.aws/credentials` automatically and calls `credentialsSupplier` on 
a `SessionCredentials` ultimately using the AWS SDK, and that works fine, and 
there is no apparent system property corresponding to the `sessionToken`. So I 
will guess I will have to find a colleague with better understanding of AWS 
authentication to assist me.

It is good to at least have confirmation that `identity` is an “access key” 
while `credential` is an “access secret” in AWS terminology—this is what would 
be useful to clarify in a `README.md`.

I am less confident in the value of a unit test or mock test since it is not 
self-evident what the actual designed signature would be. The fix is just that 
which produces a signature that Amazon in fact accepts.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1226#issuecomment-403940474

Reply via email to