This is the [jira](https://issues.apache.org/jira/browse/JCLOUDS-1415). I've wrote one test for the firewall loader, but I think it's not enough. And I've tried to make a Minimum Viable Change in order to don't have a lot of new files and things to review. Thanks for your review ! You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1236 -- Commit Summary -- * feat(firewall): add loader class * feat(resource): add GET api to get firewall by uri * feat(node/create): use firewall loader * feat(compute/service): create firewall provider * style(resources): use multilines import * perf(node/creation): remove comments * test(firewall/loader): add one test to handle not found firewall * style(node/creation): fix checkstyle violation * chore(firewall/test): add missing apache licence * perf(firewall/loader): remove space between package and licence * feat(adapter): try to get first the resource by URI * feat(node/creation): check on the full URI -- File Changes -- M providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceAdapter.java (10) M providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/config/GoogleComputeEngineServiceContextModule.java (13) M providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/Resources.java (6) A providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/loaders/FirewallLoader.java (53) M providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/strategy/CreateNodesWithGroupEncodedIntoNameThenAddToSet.java (99) A providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/loaders/FirewallLoaderTest.java (42) -- Patch Links -- https://github.com/jclouds/jclouds/pull/1236.patch https://github.com/jclouds/jclouds/pull/1236.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1236
