[
https://issues.apache.org/jira/browse/JCLOUDS-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Estevez updated JCLOUDS-1441:
------------------------------------
Description:
Right now some paths are hardcoded, so azure compute provider cannot work
correctly, this one was the main blocker:
[https://github.com/jclouds/jclouds/blob/master/providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/config/AzureComputeHttpApiModule.java#L57]
As a reference, here is a documentation for the needed endpoint translations
when using Azure regions in China
[https://docs.microsoft.com/en-us/azure/china/china-get-started-developer-guide#check-endpoints-in-azure]
Also some tests included configurations, regions and paths hardcoded that made
it hard to test, i might open an alternate PR just to fix those tests
executions.
In a local branch overriding all those problems i could execute the full set of
Live Tests with just two outstanding problems (maybe as different isolated
issues):
* GraphAPI endpoint is hardcoded here
[https://github.com/jclouds/jclouds/blob/master/providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/config/GraphRBAC.java#L38]
* VaultAPI endpoints are also hardcoded
https://github.com/jclouds/jclouds/blob/master/providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/features/VaultApi.java#L149
I will open a PR to fix those paths and allow the provider to work with China
regions, as well as adding two missing regions.
was:
Right now some paths are hardcoded, so azure compute provider cannot work
correctly, this one was the main blocker:
https://github.com/jclouds/jclouds/blob/master/providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/config/AzureComputeHttpApiModule.java#L57
As a reference, here is a documentation for the needed endpoint translations
when using Azure regions in China
[https://docs.microsoft.com/en-us/azure/china/china-get-started-developer-guide#check-endpoints-in-azure]
Also some tests included configurations, regions and paths hardcoded that made
it hard to test, i might open an alternate PR just to fix those tests
executions.
In a local branch overriding all those problems i could execute the full set of
Live Tests with just one outstanding problem (maybe as a different isolated
issue):
* GraphAPI endpoint is hardcoded here
https://github.com/jclouds/jclouds/blob/master/providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/config/GraphRBAC.java#L38
I will open a PR to fix those paths and allow the provider to work with China
regions, as well as adding two missing regions.
> [ARM] China regions can not be used
> -----------------------------------
>
> Key: JCLOUDS-1441
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1441
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-compute
> Reporter: Daniel Estevez
> Assignee: Daniel Estevez
> Priority: Major
> Labels: Azure, azurecompute-arm
> Fix For: 2.2.0
>
>
> Right now some paths are hardcoded, so azure compute provider cannot work
> correctly, this one was the main blocker:
> [https://github.com/jclouds/jclouds/blob/master/providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/config/AzureComputeHttpApiModule.java#L57]
> As a reference, here is a documentation for the needed endpoint translations
> when using Azure regions in China
> [https://docs.microsoft.com/en-us/azure/china/china-get-started-developer-guide#check-endpoints-in-azure]
> Also some tests included configurations, regions and paths hardcoded that
> made it hard to test, i might open an alternate PR just to fix those tests
> executions.
> In a local branch overriding all those problems i could execute the full set
> of Live Tests with just two outstanding problems (maybe as different isolated
> issues):
> * GraphAPI endpoint is hardcoded here
> [https://github.com/jclouds/jclouds/blob/master/providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/config/GraphRBAC.java#L38]
> * VaultAPI endpoints are also hardcoded
> https://github.com/jclouds/jclouds/blob/master/providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/features/VaultApi.java#L149
>
> I will open a PR to fix those paths and allow the provider to work with
> China regions, as well as adding two missing regions.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
