demobox commented on this pull request.
> @@ -763,6 +763,8 @@ private static void addHeader(Multimap<String, String>
> headers, Headers header,
for (int i = 0; i < header.keys().length; i++) {
String value = header.values()[i];
value = replaceTokens(value, tokenValues);
+ if (header.urlEncode().length > i && header.urlEncode()[i])
[minor] Change to `i < header.urlEncode().length && header.urlEncode()[i]`? The
bounds check seems to be written that way around more commonly, which might
make it easier to understand that's going on here
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1238#pullrequestreview-154462976
