demobox commented on this pull request.
> + MultipartPart part1 = blobStore.uploadMultipartPart(mpu, 1, > payload); + MultipartPart part2 = blobStore.uploadMultipartPart(mpu, 2, payload); + + List<MultipartPart> parts = blobStore.listMultipartUpload(mpu); + assertThat(parts).hasSize(2); + assertThat(parts.get(0).partNumber()).isEqualTo(part1.partNumber()); + assertThat(parts.get(0).partSize()).isEqualTo(part1.partSize()); + assertThat(parts.get(0).partETag()).isEqualTo(part1.partETag()); + assertThat(parts.get(1).partNumber()).isEqualTo(part2.partNumber()); + assertThat(parts.get(1).partSize()).isEqualTo(part2.partSize()); + assertThat(parts.get(1).partETag()).isEqualTo(part2.partETag()); + + blobStore.completeMultipartUpload(mpu, ImmutableList.of(part1, part2)); + + BlobMetadata newBlobMetadata = blobStore.blobMetadata(container, name); + assertThat(newBlobMetadata.getETag()).isEqualTo(expectedETag); Sorry, I wasn't clear: I think it's fine to have *fewer* validations, so it's clear to the reader immediately what the "main" point of this test is. E.g. skip the assertions on number and size of parts, if that's not what we care about here? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1252#discussion_r228362685
