nacx commented on this pull request.
Just one comment. Otherwise looks good. Thanks, @mcdonnell-john!
> @@ -400,6 +510,15 @@ protected UsageRecord(String id, @Nullable String
> description, @Nullable String
this.usageType = usageType;
this.project = project;
this.projectId = projectId;
+ this.domain = domain;
+ this.virtualSize = virtualSize;
+ this.cpuNumber = cpuNumber;
+ this.cpuSpeed = cpuSpeed;
+ this.memory = memory;
+ this.isSystem = isSystem;
+ this.networkId = networkId;
+ this.isDefault = isDefault;
Constructor param is an object and variable is a primitive type. This could
potentially cause a NPE if the parameter is `null`. We should take care of
this, and also fix it for other parameters where we use objects/primitives.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1259#pullrequestreview-179192557
