nacx approved this pull request.


>  
    @SerializedNames({ "id", "name", "location", "etag", "tags", "properties", 
"sku"})
    public static LoadBalancer create(String id, final String name, final 
String location, final String etag,
-         final Map<String, String> tags, final LoadBalancerProperties 
properties, final LoadBalancerSKU sku) {
+         final Map<String, String> tags, final LoadBalancerProperties 
properties, final SKU sku) {

Keep properties as the last parameter, for consistency.

>  
    @SerializedNames({ "name", "id", "etag", "location", "tags", "properties", 
"sku" })
    public static PublicIPAddress create(String name, String id, String etag, 
String location, Map<String, String> tags,
-         PublicIPAddressProperties properties, PublicAddressSKU sku) {
+         PublicIPAddressProperties properties, SKU sku) {

Keep properties at the end.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1264#pullrequestreview-187122482

Reply via email to