@xingyunyang This code has incorrect structure.  The s3 API is vendor-neutral 
which supports many providers by overriding the endpoint.  Please study the 
aws-s3 provider which extends the s3 API in the manner which you should 
structure your Aliyun pull request.  Also please study the unit tests for 
signing request which we will require for your new functionality.  Finally we 
require that all code merges first with master and we can evaluate backports to 
other branches.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1263#issuecomment-451692571

Reply via email to