timuralp approved this pull request.
Looks good to me!
> } else if (child.isDirectory()) {
- blobNames.add(function.apply(child.getAbsolutePath()) +
File.separator); // TODO: undo if failures
- populateBlobKeysInContainer(child, blobNames, function);
+ // Consider a prefix /a/b/c but we have only descended to path /a.
+ // We need to match the path against the prefix to continue
I was confused by the additional check here, but after removing it and running
the tests, it makes sense: the directories will not include the trailing "/",
so if the prefix is "dir/", then it wouldn't match the directory "dir"
(excluding it from the list and not listing its contents). I think this comment
helps, but maybe it could more explicitly call out this specific issues. As far
as I can tell, this only affects prefix listings that end with the file
separator.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1268#pullrequestreview-197775752
