[ 
https://issues.apache.org/jira/browse/JCLOUDS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795789#comment-16795789
 ] 

Ignasi Barrera commented on JCLOUDS-693:
----------------------------------------

That looks good. Since the parameter is optional, though, you should mark the 
getter method as {{@Nullable}} too, and do the same with the create method 
parameter. Change to {{@Nullable Boolean existing}} (note the object, not the 
primitive type to allow a {{null}} value there.

You should also update the {{StackApiMockTest}} and include a test that sends 
the new parameter to make sure the request is generated as expected.

Feel free to open a pull request to this repo 
https://github.com/apache/jclouds-labs-openstack and continue the discussion 
there

> Support OpenStack Orchestration (Heat) API
> ------------------------------------------
>
>                 Key: JCLOUDS-693
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-693
>             Project: jclouds
>          Issue Type: New Feature
>          Components: jclouds-labs-openstack
>            Reporter: Jeremy Daggett
>            Priority: Major
>              Labels: openstack, orchestration
>
> Heat is the main project in the OpenStack Orchestration program. It 
> implements an orchestration engine to launch multiple composite cloud 
> applications based on templates in the form of text files that can be treated 
> like code. A native Heat template format is evolving, but Heat also 
> endeavours to provide compatibility with the AWS CloudFormation template 
> format, so that many existing CloudFormation templates can be launched on 
> OpenStack. Heat provides both an OpenStack-native ReST API and a 
> CloudFormation-compatible Query API.
> API Docs: http://developer.openstack.org/api-ref-orchestration-v1.html
> OpenStack Heat Wiki: https://wiki.openstack.org/wiki/Heat



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to