nacx commented on a change in pull request #23: draft - disable AccessPolicy
check for SAS Authorised azureblob
URL: https://github.com/apache/jclouds/pull/23#discussion_r279364630
##########
File path:
providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/functions/BlobPropertiesToBlobMetadata.java
##########
@@ -58,6 +59,8 @@ public MutableBlobMetadata apply(BlobProperties from) {
PublicAccess containerAcl =
containerAcls.getUnchecked(from.getContainer());
if (containerAcl != PublicAccess.PRIVATE)
to.setPublicUri(from.getUrl());
+ } catch (UncheckedExecutionException ue) {
+ to.setPublicUri(from.getUrl());
Review comment:
I'm not that familiar with the contract for this API and try/catch block.
So... Sure, let's call `setPublicUri` wherever it makes sense. I just tried to
suggest a way of capturing the _real_ exception we care about.
Once we capture the exception we want, let's make sure we set the URI when
needed. I'll defer that to you, as you know the API better :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
