[
https://issues.apache.org/jira/browse/JCLOUDS-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864272#comment-16864272
]
Eran Bergman commented on JCLOUDS-1166:
---------------------------------------
[~nacx] I don't think shading is a good solution in the long run. It might
cause a lot of problems down the road:
* this breaks Maven's dependency management concept
* doesn't solve the problem for future version changes of the gson dependency
(if you want to usage of new features or vulnerabilities fixes)
* security scans might still complain about this shaded dependency as well
(depending on the scan)
* might cause all sorts of classloading/naming issues (not sure this is a
thing though)
Wouldn't it be better to have a more "real" solution?
> Remove uses of the 'com.google.gson.internal' package
> -----------------------------------------------------
>
> Key: JCLOUDS-1166
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1166
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-chef, jclouds-core
> Affects Versions: 1.9.2
> Reporter: Ignasi Barrera
> Assignee: Ignasi Barrera
> Priority: Major
> Labels: gson
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Starting from Gson 2.6, the {{com.google.gson.internal}} packages are no
> longer exported in the OSGi bundles. This makes it impossible to use jclouds
> in an OSGi environment if upgrading to such versions of Gson.
> There is no change to add the exports back for that package (see [this
> discussion|https://github.com/google/gson/pull/916]), so we should stop using
> those classes.
> See also: http://markmail.org/message/olgebygfgdy3hwtm
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
