nacx commented on a change in pull request #35: JCLOUDS-1166: Relocate the gson
internal packge to be able to keep using it
URL: https://github.com/apache/jclouds/pull/35#discussion_r294177538
##########
File path: project/pom.xml
##########
@@ -592,6 +594,30 @@
<package>com.jcraft.jsch.agentproxy</package>
</packages>
</exception>
+ <!--
+ Due to the following issues:
+ https://issues.apache.org/jira/browse/MSHADE-206
+ https://issues.apache.org/jira/browse/MNG-5899
+ The contents of the shaded gson jar are directly included as
part of jclouds-core.
Review comment:
I don't think it makes sense to force people to use an old version of Maven
just because of an issue in the Maven Shade plugin. It is a warning of the
duplicate class finder, but in this case it's safe because the offending
classes are exactly the same (as reported by the plugin too).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
