nacx commented on issue #47: J clouds 1516 URL: https://github.com/apache/jclouds/pull/47#issuecomment-539999412 JFTR, you don't need a valid account for the test. It's not a _live test_ that I'm asking for; just a mock test. You have to add a test to the [S3ClientMockTest](https://github.com/apache/jclouds/blob/master/apis/s3/src/test/java/org/jclouds/s3/S3ClientMockTest.java) class that calls the method you modified, and makes sure the generated request has the correct hostname. When writing the test, you may have to enqueue in the mock the requests generated by the `AssignCorrectHostnameForBucket`, as I think it makes a request to get the location of the bucket, and uses the response to that to build the hostname with the right region.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
