gaul commented on this pull request.
>
for (MultipartPart part : parts) {
Blob blobPart = getBlob(mpu.containerName(), MULTIPART_PREFIX +
mpu.id() + "-" + mpu.blobName() + "-" + part.partNumber());
contentLength +=
blobPart.getMetadata().getContentMetadata().getContentLength();
blobs.add(blobPart);
-
md5Hasher.putBytes(BaseEncoding.base16().lowerCase().decode(blobPart.getMetadata().getETag()));
+ if (blobPart.getMetadata().getETag() != null) {
+
md5Hasher.putBytes(BaseEncoding.base16().lowerCase().decode(blobPart.getMetadata().getETag()));
This seems reasonable, but did you consider returning an empty ETag instead? I
appreciate the commitment to S3 fidelity buy
`FilesystemStorageStrategyImpl.getBlob` already returns null ETags instead of
recalculating them. Systems without extended attributes are uncommon so is the
additional complexity worth it?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1285#pullrequestreview-369234774
