gaul commented on pull request #89:
URL: https://github.com/apache/jclouds/pull/89#issuecomment-787423235


   Have you run the integration tests?  When testing against azureblob I see:
   
   ```
   $ mvn integration-test -pl :azureblob -Plive 
-Dtest.azureblob.identity="${JCLOUDS_IDENTITY}" 
-Dtest.azureblob.credential="${JCLOUDS_CREDENTIAL}"
   ...
   
testPutMultipartByteSource(org.jclouds.azureblob.blobstore.integration.AzureBlobIntegrationLiveTest)
  Time elapsed: 3.204 sec  <<< FAILURE!
   com.google.common.util.concurrent.UncheckedExecutionException: 
java.lang.IllegalArgumentException: either chunked encoding must be set on the 
http request or contentlength set on the payload: {method=PUT, 
endpoint=https://gaultest3.blob.core.windows.net/gaul-blobstore13/multipart-upload?comp=block&blockid=AAAAAQ%3D%3D,
 headers={x-ms-version=[2017-04-17]}, payload=[content=true, 
contentMetadata=[cacheControl=null, contentDisposition=null, 
contentEncoding=null, contentLanguage=null, contentLength=null, 
contentMD5=null, contentType=application/unknown, expires=null], written=false, 
isSensitive=false]}   
           at 
com.google.common.util.concurrent.Futures.wrapAndThrowUnchecked(Futures.java:1434)
           at 
com.google.common.util.concurrent.Futures.getUnchecked(Futures.java:1419)
           at 
org.jclouds.blobstore.internal.BaseBlobStore.putMultipartBlob(BaseBlobStore.java:389)
           at 
org.jclouds.blobstore.internal.BaseBlobStore.putMultipartBlob(BaseBlobStore.java:348)
           at 
org.jclouds.azureblob.blobstore.AzureBlobStore.putBlob(AzureBlobStore.java:237)
           at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
           at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
           at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
           at java.lang.reflect.Method.invoke(Method.java:498)
           at 
com.google.inject.internal.DelegatingInvocationHandler.invoke(DelegatingInvocationHandler.java:50)
           at com.sun.proxy.$Proxy58.putBlob(Unknown Source)
           at 
org.jclouds.blobstore.integration.internal.BaseBlobIntegrationTest.testPut(BaseBlobIntegrationTest.java:843)
           at 
org.jclouds.blobstore.integration.internal.BaseBlobIntegrationTest.testPutMultipartByteSource(BaseBlobIntegrationTest.java:693)
           at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
           at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
           at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
           at java.lang.reflect.Method.invoke(Method.java:498)
           at 
org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:85)
           at org.testng.internal.Invoker.invokeMethod(Invoker.java:696)
           at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:882)
           at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1189)
           at 
org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:124)
           at 
org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:108)
           at org.testng.TestRunner.privateRun(TestRunner.java:767)
           at org.testng.TestRunner.run(TestRunner.java:617)
           at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
           at org.testng.SuiteRunner.access$000(SuiteRunner.java:38)
           at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:382)
           at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
           at java.util.concurrent.FutureTask.run(FutureTask.java:266)
           at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
           at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
           at java.lang.Thread.run(Thread.java:748)
   Caused by: java.lang.IllegalArgumentException: either chunked encoding must 
be set on the http request or contentlength set on the payload: {method=PUT, 
endpoint=https://gaultest3.blob.core.windows.net/gaul-blobstore13/multipart-upload?comp=block&blockid=AAAAAQ%3D%3D,
 headers={x-ms-version=[2017-04-17]}, payload=[content=true, 
contentMetadata=[cacheControl=null, contentDisposition=null, 
contentEncoding=null, contentLanguage=null, contentLength=null, 
contentMD5=null, contentType=application/unknown, expires=null], written=false, 
isSensitive=false]}
           at 
com.google.common.base.Preconditions.checkArgument(Preconditions.java:203)
           at 
org.jclouds.http.HttpUtils.checkRequestHasRequiredProperties(HttpUtils.java:240)
           at 
org.jclouds.rest.internal.RestAnnotationProcessor.apply(RestAnnotationProcessor.java:363)
           at 
org.jclouds.rest.internal.RestAnnotationProcessor.apply(RestAnnotationProcessor.java:137)
           at 
org.jclouds.rest.internal.InvokeHttpMethod.toCommand(InvokeHttpMethod.java:189)
           at 
org.jclouds.rest.internal.InvokeHttpMethod.invoke(InvokeHttpMethod.java:85)
           at 
org.jclouds.rest.internal.InvokeHttpMethod.apply(InvokeHttpMethod.java:74)
           at 
org.jclouds.rest.internal.InvokeHttpMethod.apply(InvokeHttpMethod.java:45)
           at 
org.jclouds.rest.internal.DelegatesToInvocationFunction.handle(DelegatesToInvocationFunction.java:156)
           at 
org.jclouds.rest.internal.DelegatesToInvocationFunction.invoke(DelegatesToInvocationFunction.java:123)
           at com.sun.proxy.$Proxy57.putBlock(Unknown Source)
           at 
org.jclouds.azureblob.blobstore.AzureBlobStore.uploadMultipartPart(AzureBlobStore.java:445)
           at 
org.jclouds.blobstore.internal.BaseBlobStore$BlobUploader.call(BaseBlobStore.java:409)
           at 
org.jclouds.blobstore.internal.BaseBlobStore$BlobUploader.call(BaseBlobStore.java:396)
           at 
com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:111)
           at 
com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:58)
           at 
com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:75)
           at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
           at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
           at java.lang.Thread.run(Thread.java:748)
           at java.lang.Thread.getStackTrace(Thread.java:1559)
           at 
org.jclouds.blobstore.internal.BaseBlobStore.putMultipartBlob(BaseBlobStore.java:384)
           at 
org.jclouds.blobstore.internal.BaseBlobStore.putMultipartBlob(BaseBlobStore.java:348)
           at 
org.jclouds.azureblob.blobstore.AzureBlobStore.putBlob(AzureBlobStore.java:237)
           at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
           at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
           at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
           at java.lang.reflect.Method.invoke(Method.java:498)
           at 
com.google.inject.internal.DelegatingInvocationHandler.invoke(DelegatingInvocationHandler.java:50)
           at com.sun.proxy.$Proxy58.putBlob(Unknown Source)
           at 
org.jclouds.blobstore.integration.internal.BaseBlobIntegrationTest.testPut(BaseBlobIntegrationTest.java:843)
           at 
org.jclouds.blobstore.integration.internal.BaseBlobIntegrationTest.testPutMultipartByteSource(BaseBlobIntegrationTest.java:693)
           at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
           at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
           at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
           at java.lang.reflect.Method.invoke(Method.java:498)
           at 
org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:85)
           at org.testng.internal.Invoker.invokeMethod(Invoker.java:696)
           at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:882)
           at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1189)
           at 
org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:124)
           at 
org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:108)
           at org.testng.TestRunner.privateRun(TestRunner.java:767)
           at org.testng.TestRunner.run(TestRunner.java:617)
           at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
           at org.testng.SuiteRunner.access$000(SuiteRunner.java:38)
           at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:382)
           at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
           at java.util.concurrent.FutureTask.run(FutureTask.java:266)
           at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
           at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
           at java.lang.Thread.run(Thread.java:748)
   ...
   Failed tests:
     
AzureBlobIntegrationLiveTest>BaseBlobIntegrationTest.testGetRangeMultipart:482 
» UncheckedExecution
     
AzureBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutBlobTierInfrequentMultipart:793->BaseBlobIntegrationTest.testPutBlobTierHelper:812
 » UncheckedExecution
     
AzureBlobIntegrationLiveTest.testPutBlobAccessMultipart:76->BaseBlobIntegrationTest.testPutBlobAccessMultipart:759
 » UncheckedExecution
     
AzureBlobIntegrationLiveTest>BaseBlobIntegrationTest.testMultipartUploadNoPartsAbort:1302
   Expecting:
    <[MultipartPart{partNumber=1, partSize=1, partETag=, lastModified=null}]>
   to be equal to:
    <[]>
   but was not.
     
AzureBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutMultipartByteSource:693->BaseBlobIntegrationTest.testPut:843
 » UncheckedExecution
     
AzureBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutBlobTierArchiveMultipart:798->BaseBlobIntegrationTest.testPutBlobTierHelper:812
 » UncheckedExecution
     
AzureBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutBlobTierStandardMultipart:788->BaseBlobIntegrationTest.testPutBlobTierHelper:812
 » UncheckedExecution
     
AzureBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutMultipartInputStream:701->BaseBlobIntegrationTest.testPut:843
 » IllegalArgument
     
AzureBlobIntegrationLiveTest>BaseBlobIntegrationTest.testCopyIfNoneMatchNegative:1164
   Expecting:
    <304>
   to be equal to:
    <412>
   but was not.
     AzureBlobClientLiveTest.testCopyBlobIfModifiedSince:469 » HttpResponse 
command...
     AzureBlobClientLiveTest.testCopyBlobIfNoneMatch:552 » HttpResponse 
command: PU...
   
   Tests run: 142, Failures: 11, Errors: 0, Skipped: 12
   ```
   
   There are some spuriously failing tests but I expect that this PR should not 
introduce new failures.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to