jiffysrc commented on a change in pull request #125: URL: https://github.com/apache/jclouds/pull/125#discussion_r780900083
########## File path: apis/s3/src/main/java/org/jclouds/s3/config/S3HttpApiModule.java ########## @@ -184,7 +184,7 @@ protected void bindErrorHandlers() { } protected void bindRequestSigner() { - bind(RequestAuthorizeSignature.class).to(RequestAuthorizeSignatureV2.class).in(Scopes.SINGLETON); + bind(RequestAuthorizeSignature.class).to(RequestAuthorizeSignatureV4.class).in(Scopes.SINGLETON); Review comment: Hi @nacx Could you please provide feedback on above approach, @gaul Will you be completing the remaining change on this PR/move code around. https://github.com/gaul/jclouds-1/pull/new/s3/signer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@jclouds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org