gaul commented on code in PR #163:
URL: https://github.com/apache/jclouds/pull/163#discussion_r1083391573


##########
blobstore/src/main/java/org/jclouds/blobstore/config/LocalBlobStore.java:
##########
@@ -739,14 +738,8 @@ public Blob getBlob(String containerName, String key, 
GetOptions options) {
       Payload payload;
       try {
          InputStream is = blob.getPayload().openStream();
-         if (is instanceof FileInputStream) {
-            // except for FileInputStream since large MPU can open too many fds
-            is.close();

Review Comment:
   A subsequent PR will return a `FileInputStream` instead of a `ByteSource` to 
fix a race condition in the filesystem blobstore so this code cannot assume 
that the `Payload` is a repeatable `ByteSource` that can be re-opened.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to