jixinchi commented on code in PR #203:
URL: https://github.com/apache/jclouds/pull/203#discussion_r1565125481
##########
apis/filesystem/src/main/java/org/jclouds/filesystem/predicates/validators/internal/FilesystemBlobKeyValidatorImpl.java:
##########
@@ -38,6 +38,8 @@ public void validate(String name) throws
IllegalArgumentException {
//blobkey cannot start with / (or \ in Windows) character
if (name.startsWith("\\") || name.startsWith("/"))
throw new IllegalArgumentException("Blob key '" + name + "' cannot
start with \\ or /");
+ if (name.contains("../"))
+ throw new IllegalArgumentException("Blob key '" + name + "' cannot
contain ../");
Review Comment:
I think `..foo` should be allowed. I tried several object storage services,
such as gcloud and aliyun oss, they all allow `..foo` as object key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@jclouds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
